Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ability to fine tune custom model on conversable agents #1787

Merged
merged 15 commits into from
Mar 11, 2024

Conversation

olgavrou
Copy link
Member

@olgavrou olgavrou commented Feb 26, 2024

Why are these changes needed?

Agent's with custom models should be able to accept feedback and fine tune their underlying models.

Related issue number

Checks

@codecov-commenter
Copy link

codecov-commenter commented Feb 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 37.33%. Comparing base (4a85b63) to head (6433cd1).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1787   +/-   ##
=======================================
  Coverage   37.33%   37.33%           
=======================================
  Files          64       64           
  Lines        6913     6913           
  Branches     1519     1519           
=======================================
  Hits         2581     2581           
  Misses       4109     4109           
  Partials      223      223           
Flag Coverage Δ
unittests 37.33% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@olgavrou olgavrou marked this pull request as ready for review March 5, 2024 22:23
@olgavrou olgavrou requested review from ekzhu and BeibinLi March 5, 2024 22:47
autogen/oai/client.py Outdated Show resolved Hide resolved
Copy link
Collaborator

@BeibinLi BeibinLi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks so much for this PR. Very needed!

I think we may want to add a very brief working example here. Let's brainstorm together.

Copy link
Collaborator

@ekzhu ekzhu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider subclassing the core lib instead of modifying it so changes in this tool can move fast by itself.

autogen/oai/client.py Outdated Show resolved Hide resolved
Copy link
Collaborator

@ekzhu ekzhu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we can remove the skips for the tests as all of them do not require OpenAI.

Copy link
Collaborator

@BeibinLi BeibinLi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for the hard work!

@sonichi sonichi added this pull request to the merge queue Mar 11, 2024
Merged via the queue into microsoft:main with commit ce71d85 Mar 11, 2024
26 checks passed
whiskyboy pushed a commit to whiskyboy/autogen that referenced this pull request Apr 17, 2024
* uAbility to update_model on conversable agents

* formatting

* formatting

* move code from conversable agent into samples/tools and add testing and README

* forgot install step

* fix

* leave core lib unchanged and move everything to samples/tools

* remove skip openai

---------

Co-authored-by: Eric Zhu <ekzhu@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants